Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional validation to Create Model form #116

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

dustins
Copy link
Contributor

@dustins dustins commented Sep 26, 2024

Issue #, if available:

Description of changes:
Added some enhancements to the Create Model form to help prevent invalid settings.

  • added (optional) label to Model URL
  • Model Id validator now has character limits
  • Instance Type & Inference Container now are required if LISA Hosted Model is true

Recording 2024-09-26 at 15 06 18

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

estohlmann
estohlmann previously approved these changes Sep 26, 2024
@dustins dustins merged commit 100030e into develop Sep 26, 2024
4 checks passed
@estohlmann estohlmann deleted the enhancement/create-form-validation-20240926 branch October 1, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants