Model Management: Enable update form #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermuller
reviewed
Sep 25, 2024
lib/user-interface/react/src/components/model-management/create-model/CreateModelModal.tsx
Show resolved
Hide resolved
estohlmann
approved these changes
Sep 26, 2024
estohlmann
reviewed
Sep 26, 2024
| @@ -113,8 +113,8 @@ function ModelActionButton (dispatch: ThunkDispatch<any, any, Action>, notificat | |||
| items.push({ | |||
| text: 'Update', | |||
| id: 'editModel', | |||
| disabled: true, | |||
| disabledReason: 'This action will be available with LISA release 3.0.1', | |||
| disabled: !selectedModel, | |||
There was a problem hiding this comment.
Non blocking: We don't technically need to do this since the parent dropdown is disabled if we don't have a model selected.
There was a problem hiding this comment.
Yeah I went back and forth on this. I liked this because if we change when the menu is disabled this would keep working. But it is superfluous now so I can remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
LISA 3.0 launched with model management but didn't have updating models enabled yet. This PR add the ability to configure a few model properties after launch.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.