chore: update stateful resumption doc #4818
Open
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
reviewed
Oct 4, 2024
Comment on lines
+28
to
+29
| Applications must perform a graceful TSL shutdown in order to be able to resume a session with session caching. If the connection results in abrupt termination (i.e, no `close_notify` alert is received by server), the session cache will be deleted and therefore will fail to resume. For more information on how to close connections, see [Closing the Connection](./ch07-io.md#closing-the-connection) | ||
|
|
There was a problem hiding this comment.
I think it's worth mentioning that the cached session will be deleted on any error. Customers may not expect that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
When attempting to perform session resumption using session caching, the TLS connection must be closed gracefully. If not, the session cache is deleted from the server, leading to a failed resumption and triggering a full handshake instead. We should document this behavior and update the usage guide.
Description of changes:
Updated usage guide and documented stateful resumption behavior.
Call-outs:
Stateless session resumption behaves differently as it is able to resume a session without graceful TLS shutdown. This shouldn't have security implications as stated in RFC5077:
Testing:
No functional changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.