feat(bindings): add set receive buffering to the rust bindings #4817
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
reviewed
Oct 3, 2024
lrstewart
approved these changes
Oct 3, 2024
jmayclin
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Not in scope for this PR, but I wonder if we should be turning this on by default for the rust bindings?
We could either make this the default everywhere for the rust bindings across a version bump, or maybe we could just make it the default for the tokio bindings? Since everyone using the tokio bindings has the same IO implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add rust bindings
connection.set_receive_buffering(enabled)which correspond tos2n_connection_set_recv_buffering.The C api was added in #4485 that provides performance by reducing recv syscalls eariler, this change updates the
s2n-tlsrust api to enable this feature.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.