chore: remove unused compile definition #4815
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
DS2N_BLOCK_NONPORTABLE_OPTIMIZATIONSis not referenced anywhere in the codebase. Setting it to true or false is a no-op and does not change anything.This was previously used for the s2n-tls copy of pq stuff but now that the PQ code has been moved to AWS-LC the compile definition is unused.
I grep'd through our codebase for
S2N_BLOCK_NONPORTABLE_OPTIMIZATIONSand removed all references to it.Testing:
All CI should pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.