refactor(bindings): add general bindings error context #4811
+40
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
force-pushed
the
bindings_error
branch
from
cb4e221
to
8f95b15
Compare
lrstewart
commented
Oct 1, 2024
| #[derive(Debug, PartialEq)] | ||
| #[derive(Copy, Clone, Debug, PartialEq)] |
There was a problem hiding this comment.
@camshaft you mentioned you're not a fan of Copy in #4764 (comment). Do you think we can get away with it here, since it's more for reading than writing, or should I still avoid it? Things work fine with clone, it's just slightly more annoying to deal with.
There was a problem hiding this comment.
Copy is usually fine, it just means you need to keep in mind how you end up using it (I think shared an example issue that can arise in the other comment)
There was a problem hiding this comment.
This type should be ok though
camshaft
approved these changes
Oct 2, 2024
jmayclin
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
I'm just going to keep pulling bits out of #4764 until it gets approved :)
Description of changes:
Adding a new error currently involves updating a bunch of very repetitive match statements. Switch to a more flexible solution.
Testing:
Added a little unit test. I also switched our two existing errors to use the new context, and those errors are used throughout the bindings.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.