-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional e2e tests for up down arrow navigation #205
Conversation
...ests/__test__/flows/navigate-prompts/navigate-back-to-current-prompt-with-code-attachment.ts
Show resolved
Hide resolved
...romium/main-spec-ts-open-mynah-ui-prompt-navigation-should-stay-on-current-prompt-1-snap.png
Outdated
Show resolved
Hide resolved
ui-tests/__test__/flows/navigate-prompts/stay-on-current-prompt.ts
Outdated
Show resolved
Hide resolved
...ests/__test__/flows/navigate-prompts/navigate-back-to-current-prompt-with-code-attachment.ts
Show resolved
Hide resolved
...ests/__test__/flows/navigate-prompts/navigate-back-to-current-prompt-with-code-attachment.ts
Show resolved
Hide resolved
From my local testing, it looks like the "Prompt navigation" tests are being affected by the "should parse markdown" test. In the markdown tests, we update the viewport size of the page using This could be fixed by having a setup that resets the page viewport after each test. For example adding |
Problem
Add e2e test coverage for up/down arrow navigation, testing scenarios where the prompt is not sent, and when there is a code attachment inside the prompt.
We also rename some old tests for consistency with test naming.
Tests
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.