Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional e2e tests for up down arrow navigation #205

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

francescoopiccoli
Copy link
Contributor

Problem

Add e2e test coverage for up/down arrow navigation, testing scenarios where the prompt is not sent, and when there is a code attachment inside the prompt.
We also rename some old tests for consistency with test naming.

Tests

  • I have tested this change on VSCode
  • I have tested this change on JetBrains

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@francescoopiccoli francescoopiccoli marked this pull request as ready for review December 16, 2024 14:38
@francescoopiccoli francescoopiccoli requested a review from a team as a code owner December 16, 2024 14:38
Jurredr
Jurredr previously approved these changes Dec 16, 2024
@natdurlik
Copy link
Contributor

natdurlik commented Dec 17, 2024

From my local testing, it looks like the "Prompt navigation" tests are being affected by the "should parse markdown" test. In the markdown tests, we update the viewport size of the page using page.setViewportSize. The Failing screenshots can be reproduced by adding an "only" mark to these two test suites.

This could be fixed by having a setup that resets the page viewport after each test. For example adding await page.setViewportSize(DEFAULT_VIEWPORT); in the beforeEach clause to ensure a consistent viewport size across tests. (This also cloud be fixed by changing the order of tests in source code, so that the markdown tests are the last in the file, but it's not the right solution.)

@Jurredr Jurredr merged commit 7d022f8 into main Dec 19, 2024
2 checks passed
@Jurredr Jurredr deleted the frapicc/new-tests-e2e-up-down-arrow-navigation branch December 19, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants