Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax fallback colors #192

Merged
merged 6 commits into from
Nov 29, 2024
Merged

Conversation

Jurredr
Copy link
Contributor

@Jurredr Jurredr commented Nov 28, 2024

Problem

The updated syntax highlighting colors were causing some weird highlighting in several themes.

Solution

Add in some fallback color variables, with the initial values before the PR that updated them was merged.

Tests -> NA

  • I have tested this change on VSCode
  • I have tested this change on JetBrains

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Jurredr Jurredr added the improvement Improvement of an existing feature label Nov 28, 2024
@Jurredr Jurredr self-assigned this Nov 28, 2024
@Jurredr Jurredr requested a review from a team as a code owner November 28, 2024 16:10
src/styles/_variables.scss Outdated Show resolved Hide resolved
@dogusata dogusata merged commit 929a1f7 into main Nov 29, 2024
2 checks passed
@dogusata dogusata deleted the jurredr/add-syntax-fallback-colors branch November 29, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants