Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add pipeline override command #5034

Merged
merged 18 commits into from
Jul 6, 2023
Merged

chore: add pipeline override command #5034

merged 18 commits into from
Jul 6, 2023

Conversation

Varun359
Copy link
Contributor

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@Varun359 Varun359 requested a review from a team as a code owner June 29, 2023 18:09
@Varun359 Varun359 requested review from efekarakus and removed request for a team June 29, 2023 18:09
@github-actions
Copy link

github-actions bot commented Jun 29, 2023 •
edited
Loading

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 51152 50748 +0.80
macOS (arm) 51336 50956 +0.75
linux (amd) 45028 44680 +0.78
linux (arm) 43332 43012 +0.74
windows (amd) 41868 41548 +0.77

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023 •
edited
Loading

Codecov Report

Merging #5034 (8a587d4) into mainline (99b009c) will decrease coverage by 0.19%.
The diff coverage is 34.41%.

@@             Coverage Diff              @@
##           mainline    #5034      +/-   ##
============================================
- Coverage     69.97%   69.79%   -0.19%     
============================================
  Files           291      292       +1     
  Lines         42321    42506     +185     
  Branches        285      285              
============================================
+ Hits          29615    29665      +50     
- Misses        11269    11399     +130     
- Partials       1437     1442       +5
Impacted Files Coverage Δ
internal/pkg/cli/env_override.go 29.70% <0.00%> (ø)
internal/pkg/cli/pipeline.go 0.00% <0.00%> (ø)
internal/pkg/cli/svc_override.go 30.82% <0.00%> (ø)
internal/pkg/workspace/workspace.go 73.97% <0.00%> (-0.34%) ⬇️
internal/pkg/cli/pipeline_package.go 51.64% <6.15%> (-20.36%) ⬇️
internal/pkg/cli/pipeline_override.go 32.00% <32.00%> (ø)
internal/pkg/cli/pipeline_deploy.go 57.46% <70.83%> (+0.47%) ⬆️
internal/pkg/cli/deploy/override.go 77.41% <100.00%> (+2.41%) ⬆️
internal/pkg/cli/override.go 81.55% <100.00%> (ø)
internal/pkg/deploy/cloudformation/pipeline.go 83.95% <100.00%> (-0.39%) ⬇️
... and 2 more

... and 1 file with indirect coverage changes

dannyrandall
dannyrandall reviewed Jun 30, 2023
View reviewed changes
internal/pkg/cli/deploy/override.go Show resolved Hide resolved
internal/pkg/cli/env_override.go Outdated Show resolved Hide resolved
internal/pkg/cli/pipeline_deploy.go Outdated Show resolved Hide resolved
internal/pkg/template/overrides.go Outdated Show resolved Hide resolved
internal/pkg/template/templates/overrides/cdk/bin/override.ts Show resolved Hide resolved
internal/pkg/deploy/cloudformation/pipeline.go Outdated Show resolved Hide resolved
internal/pkg/cli/pipeline_package.go Outdated Show resolved Hide resolved
internal/pkg/cli/pipeline_override.go Show resolved Hide resolved
internal/pkg/cli/pipeline_override.go Outdated Show resolved Hide resolved
internal/pkg/cli/pipeline_override.go Outdated Show resolved Hide resolved
iamhopaul123
iamhopaul123 reviewed Jul 1, 2023
View reviewed changes
internal/pkg/cli/interfaces.go Outdated Show resolved Hide resolved
internal/pkg/deploy/cloudformation/pipeline_test.go Outdated Show resolved Hide resolved
internal/pkg/cli/pipeline_override.go Outdated Show resolved Hide resolved
internal/pkg/cli/svc_override.go Outdated Show resolved Hide resolved
dannyrandall
dannyrandall reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@dannyrandall dannyrandall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! just a few small things and a question!

internal/pkg/cli/interfaces.go Outdated Show resolved Hide resolved
internal/pkg/cli/pipeline_deploy_test.go Outdated Show resolved Hide resolved
internal/pkg/cli/pipeline_deploy_test.go Outdated Show resolved Hide resolved
internal/pkg/cli/pipeline_override.go Outdated Show resolved Hide resolved
internal/pkg/cli/pipeline_override.go Outdated Show resolved Hide resolved
internal/pkg/cli/pipeline_override.go Outdated Show resolved Hide resolved
internal/pkg/cli/pipeline_package.go Outdated Show resolved Hide resolved
internal/pkg/template/templates/overrides/cdk/stack.ts Outdated Show resolved Hide resolved
internal/pkg/template/templates/overrides/cdk/stack.ts Outdated Show resolved Hide resolved
This was referenced Jul 5, 2023
Closed
Closed
dannyrandall
dannyrandall approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@dannyrandall dannyrandall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

internal/pkg/cli/pipeline_override.go Outdated Show resolved Hide resolved
internal/pkg/cli/pipeline_override.go Outdated Show resolved Hide resolved
@dannyrandall dannyrandall added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jul 6, 2023
iamhopaul123
iamhopaul123 approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@iamhopaul123 iamhopaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit

internal/pkg/cli/pipeline_deploy.go Outdated Show resolved Hide resolved
@Varun359 Varun359 removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jul 6, 2023
@mergify mergify bot merged commit 28f0de0 into aws:mainline Jul 6, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huanjani huanjani huanjani left review comments

@dannyrandall dannyrandall dannyrandall approved these changes

@iamhopaul123 iamhopaul123 iamhopaul123 approved these changes

@efekarakus efekarakus Awaiting requested review from efekarakus efekarakus is a code owner automatically assigned from aws/aws-ecs-devx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Varun359 @codecov-commenter @dannyrandall @iamhopaul123 @huanjani