chore: add alias to the URI and listener rule (#2320)

<!-- Provide summary of changes -->
Part of #1188. Preceding PR #2315. This PR:
- add alias to the URI
- add alias to the listener rule
- enable path routing for HTTPS
- move stack related behaviors in `describe` to `describe/stack` pkg
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Makefile

@@ -158,7 +158,7 @@ gen-mocks: tools
 	${GOBIN}/mockgen -package=mocks -destination=./internal/pkg/describe/mocks/mock_backend_service.go -source=./internal/pkg/describe/backend_service.go
 	${GOBIN}/mockgen -package=mocks -destination=./internal/pkg/describe/mocks/mock_service.go -source=./internal/pkg/describe/service.go
 	${GOBIN}/mockgen -package=mocks -destination=./internal/pkg/describe/mocks/mock_describe.go -source=./internal/pkg/describe/describe.go
-	${GOBIN}/mockgen -package=mocks -destination=./internal/pkg/describe/mocks/mock_stack.go -source=./internal/pkg/describe/stack.go
+	${GOBIN}/mockgen -package=mocks -destination=./internal/pkg/describe/stack/mocks/mock_stack.go -source=./internal/pkg/describe/stack/stack.go
 	${GOBIN}/mockgen -package=mocks -destination=./internal/pkg/describe/mocks/mock_status.go -source=./internal/pkg/describe/status.go
 	${GOBIN}/mockgen -package=mocks -destination=./internal/pkg/describe/mocks/mock_pipeline_show.go -source=./internal/pkg/describe/pipeline_show.go
 	${GOBIN}/mockgen -package=mocks -destination=./internal/pkg/describe/mocks/mock_pipeline_status.go -source=./internal/pkg/describe/pipeline_status.go

cf-custom-resources/lib/env-controller.js

@@ -333,4 +333,4 @@ exports.deadlineExpired = function () {
  */
 exports.withDefaultResponseURL = function (url) {
   defaultResponseURL = url;
-};
+};

internal/pkg/aws/codepipeline/codepipeline.go

@@ -155,7 +155,7 @@ func (c *CodePipeline) GetPipeline(name string) (*Pipeline, error) {
 // Example output:
 //   DeployTo-test	Deploy	Cloudformation	stackname: dinder-test-test
 func (s *Stage) HumanString() string {
-	return fmt.Sprintf("  %s\t%s\t%s\t%s\n", s.Name, s.Category, s.Provider, s.Details)
+	return fmt.Sprintf("%s\t%s\t%s\t%s\n", s.Name, s.Category, s.Provider, s.Details)
 }
 
 // ListPipelineNamesByTags retrieves the names of all pipelines for an application.

internal/pkg/cli/env_show_test.go

@@ -10,6 +10,7 @@ import (
 
 	"github.com/aws/copilot-cli/internal/pkg/config"
 	"github.com/aws/copilot-cli/internal/pkg/describe"
+	"github.com/aws/copilot-cli/internal/pkg/describe/stack"
 	"github.com/aws/copilot-cli/internal/pkg/term/color"
 
 	"testing"
@@ -229,7 +230,7 @@ func TestEnvShow_Execute(t *testing.T) {
 		Name: "testSvc3",
 		Type: "load-balanced",
 	}
-	var wantedResources = []*describe.CfnResource{
+	var wantedResources = []*stack.Resource{
 		{
 			Type:       "AWS::IAM::Role",
 			PhysicalID: "testApp-testEnv-CFNExecutionRole",

internal/pkg/cli/svc_deploy.go

@@ -449,27 +449,27 @@ func (o *deploySvcOpts) showSvcURI() error {
 		URI(string) (string, error)
 	}
 
-	var svcDescriber identifier
+	var ecsSvcDescriber identifier
 	var err error
 	switch o.targetSvc.Type {
 	case manifest.LoadBalancedWebServiceType:
-		svcDescriber, err = describe.NewLBWebServiceDescriber(describe.NewLBWebServiceConfig{
+		ecsSvcDescriber, err = describe.NewLBWebServiceDescriber(describe.NewLBWebServiceConfig{
 			NewServiceConfig: describe.NewServiceConfig{
 				App:         o.appName,
 				Svc:         o.name,
 				ConfigStore: o.store,
 			},
 		})
 	case manifest.RequestDrivenWebServiceType:
-		svcDescriber, err = describe.NewRDWebServiceDescriber(describe.NewRDWebServiceConfig{
+		ecsSvcDescriber, err = describe.NewRDWebServiceDescriber(describe.NewRDWebServiceConfig{
 			NewServiceConfig: describe.NewServiceConfig{
 				App:         o.appName,
 				Svc:         o.name,
 				ConfigStore: o.store,
 			},
 		})
 	case manifest.BackendServiceType:
-		svcDescriber, err = describe.NewBackendServiceDescriber(describe.NewBackendServiceConfig{
+		ecsSvcDescriber, err = describe.NewBackendServiceDescriber(describe.NewBackendServiceConfig{
 			NewServiceConfig: describe.NewServiceConfig{
 				App:         o.appName,
 				Svc:         o.name,
@@ -483,7 +483,7 @@ func (o *deploySvcOpts) showSvcURI() error {
 		return fmt.Errorf("create describer for service type %s: %w", o.targetSvc.Type, err)
 	}
 
-	uri, err := svcDescriber.URI(o.targetEnvironment.Name)
+	uri, err := ecsSvcDescriber.URI(o.targetEnvironment.Name)
 	if err != nil {
 		return fmt.Errorf("get uri for environment %s: %w", o.targetEnvironment.Name, err)
 	}

internal/pkg/cli/svc_exec_test.go

@@ -23,7 +23,7 @@ import (
 type execSvcMocks struct {
 	storeSvc           *mocks.Mockstore
 	sel                *mocks.MockdeploySelector
-	svcDescriber       *mocks.MockserviceDescriber
+	ecsSvcDescriber    *mocks.MockserviceDescriber
 	ecsCommandExecutor *mocks.MockecsCommandExecutor
 	ssmPluginManager   *mocks.MockssmPluginManager
 	prompter           *mocks.Mockprompter
@@ -497,7 +497,7 @@ func TestSvcExec_Execute(t *testing.T) {
 					m.storeSvc.EXPECT().GetEnvironment("mockApp", "mockEnv").Return(&config.Environment{
 						Name: "my-env",
 					}, nil),
-					m.svcDescriber.EXPECT().DescribeService("mockApp", "mockEnv", "mockSvc").Return(nil, mockError),
+					m.ecsSvcDescriber.EXPECT().DescribeService("mockApp", "mockEnv", "mockSvc").Return(nil, mockError),
 				)
 			},
 			wantedError: fmt.Errorf("describe ECS service for mockSvc in environment mockEnv: some error"),
@@ -509,7 +509,7 @@ func TestSvcExec_Execute(t *testing.T) {
 					m.storeSvc.EXPECT().GetEnvironment("mockApp", "mockEnv").Return(&config.Environment{
 						Name: "my-env",
 					}, nil),
-					m.svcDescriber.EXPECT().DescribeService("mockApp", "mockEnv", "mockSvc").Return(&ecs.ServiceDesc{
+					m.ecsSvcDescriber.EXPECT().DescribeService("mockApp", "mockEnv", "mockSvc").Return(&ecs.ServiceDesc{
 						Tasks: []*awsecs.Task{},
 					}, nil),
 				)
@@ -524,7 +524,7 @@ func TestSvcExec_Execute(t *testing.T) {
 					m.storeSvc.EXPECT().GetEnvironment("mockApp", "mockEnv").Return(&config.Environment{
 						Name: "my-env",
 					}, nil),
-					m.svcDescriber.EXPECT().DescribeService("mockApp", "mockEnv", "mockSvc").Return(&ecs.ServiceDesc{
+					m.ecsSvcDescriber.EXPECT().DescribeService("mockApp", "mockEnv", "mockSvc").Return(&ecs.ServiceDesc{
 						Tasks: []*awsecs.Task{
 							{
 								TaskArn:    aws.String(mockTaskARN),
@@ -544,7 +544,7 @@ func TestSvcExec_Execute(t *testing.T) {
 					m.storeSvc.EXPECT().GetEnvironment("mockApp", "mockEnv").Return(&config.Environment{
 						Name: "my-env",
 					}, nil),
-					m.svcDescriber.EXPECT().DescribeService("mockApp", "mockEnv", "mockSvc").Return(&ecs.ServiceDesc{
+					m.ecsSvcDescriber.EXPECT().DescribeService("mockApp", "mockEnv", "mockSvc").Return(&ecs.ServiceDesc{
 						ClusterName: "mockCluster",
 						Tasks: []*awsecs.Task{
 							{
@@ -570,7 +570,7 @@ func TestSvcExec_Execute(t *testing.T) {
 					m.storeSvc.EXPECT().GetEnvironment("mockApp", "mockEnv").Return(&config.Environment{
 						Name: "my-env",
 					}, nil),
-					m.svcDescriber.EXPECT().DescribeService("mockApp", "mockEnv", "mockSvc").Return(&ecs.ServiceDesc{
+					m.ecsSvcDescriber.EXPECT().DescribeService("mockApp", "mockEnv", "mockSvc").Return(&ecs.ServiceDesc{
 						ClusterName: "mockCluster",
 						Tasks: []*awsecs.Task{
 							{
@@ -612,7 +612,7 @@ func TestSvcExec_Execute(t *testing.T) {
 			mocks := execSvcMocks{
 				storeSvc:           mockStoreReader,
 				ecsCommandExecutor: mockCommandExecutor,
-				svcDescriber:       mockSvcDescriber,
+				ecsSvcDescriber:    mockSvcDescriber,
 			}
 
 			tc.setupMocks(mocks)

internal/pkg/deploy/cloudformation/stack/env.go

@@ -35,6 +35,7 @@ const (
 	envParamToolsAccountPrincipalKey = "ToolsAccountPrincipalARN"
 	envParamAppDNSKey                = "AppDNSName"
 	envParamAppDNSDelegationRoleKey  = "AppDNSDelegationRole"
+	EnvParamAliasesKey               = "Aliases"
 
 	// Output keys.
 	EnvOutputVPCID               = "VpcId"