feat(blueprint): include an instantiation object on the base blueprint #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexforsyth
commented
Jan 5, 2024
| @@ -59,6 +59,9 @@ export class Blueprint extends Project { | |||
| name: process.env.CONTEXT_PROJECTNAME, | |||
| bundlepath: process.env.EXISTING_BUNDLE_ABS, | |||
| options: getOptions(path.join(process.env.EXISTING_BUNDLE_ABS || '', OPTIONS_FILE)), | |||
| blueprint: { | |||
There was a problem hiding this comment.
Should this be blueprints?
this.context.project.blueprint.instantiations
or
this.context.project.blueprints.instantiations
There was a problem hiding this comment.
I think what you have makes sense since the ancestor is singular.
There was a problem hiding this comment.
Okay fair enough
skeppeler
approved these changes
Jan 5, 2024
| @@ -59,6 +59,9 @@ export class Blueprint extends Project { | |||
| name: process.env.CONTEXT_PROJECTNAME, | |||
| bundlepath: process.env.EXISTING_BUNDLE_ABS, | |||
| options: getOptions(path.join(process.env.EXISTING_BUNDLE_ABS || '', OPTIONS_FILE)), | |||
| blueprint: { | |||
There was a problem hiding this comment.
I think what you have makes sense since the ancestor is singular.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We'd like to surface the available instantiations on the base blueprint.
this can be accessed through the instantiation object on the project context
Description
What does this implement? Explain your changes.
Testing
See test blueprint
Additional context
Add any other context about the PR here.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.