Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: builder blueprint repository name hidden tag issue #428

Merged
merged 2 commits into from
Nov 14, 2023
Merged

fix: builder blueprint repository name hidden tag issue #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
263e305
fix: builder blueprint repository name hidden tag issue
KevinDing1 Nov 13, 2023
217e3b7
Merge branch 'main' into Fix/RepoName
KevinDing1 Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions packages/blueprints/blueprint-builder/src/blueprint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,6 @@ export interface Options extends ParentOptions {
* @validationMessage This contains characters that are not allowed in NPM package names.
*/
blueprintPackageName?: string;

/**
* The repository in which your blueprint code is stored
* @hidden
* @validationRegex /^[a-zA-Z0-9_-\s]+$/
* @validationMessage Must contain only upper and lowercase letters, numbers and underscores, spaces, dashes
*/
repositoryName?: string;
};
}

Expand All @@ -82,7 +74,6 @@ export class Blueprint extends ParentBlueprint {
const spaceName = process.env.CONTEXT_SPACENAME || '<<unknown-space>>';
const dashName = decamelize.default(options_.blueprintName.toString()).replace(/[_ ]/g, '-');
const defaultPackageName = `@amazon-codecatalyst/${spaceName}.${dashName}`.substring(0, 214).toLocaleLowerCase().replace(/[_ ]/g, '-');
options_.advancedSettings.repositoryName = options_.advancedSettings.repositoryName || dashName;
options_.advancedSettings.blueprintPackageName = options_.advancedSettings.blueprintPackageName || defaultPackageName;
super(options_);
/**
Expand All @@ -103,7 +94,7 @@ export class Blueprint extends ParentBlueprint {
// eslint-disable-next-line @typescript-eslint/no-explicit-any

const repository = new SourceRepository(this, {
title: options_.advancedSettings.repositoryName,
title: dashName,
});
this.repository = repository;
this.repository.setResynthStrategies([
Expand Down
1 change: 0 additions & 1 deletion packages/blueprints/blueprint-builder/src/defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"authorName": "Amazing author",
"advancedSettings": {
"blueprintPackageName": "",
"repositoryName": "",
"license": "Apache-2.0",
"tags": ["first-label", "second-label"]
}
Expand Down