Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry: add amazonq_utgGenerateTests metric with types #934

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

chungjac
Copy link
Contributor

@chungjac chungjac commented Dec 5, 2024

Problem

amazonq_utgGenerateTests metric is in two different aws toolkit repos, jetbrains and vscode

Solution

Refactoring by moving amazonq_utgGenerateTests metric with types to this common file, which eliminates redundancy between the other toolkit repos

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chungjac chungjac requested a review from a team as a code owner December 5, 2024 22:54
Copy link
Contributor

@justinmk3 justinmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for upstreaming this! lgtm after lint CI issue is fixed

@chungjac chungjac changed the title add amazonq_utgGenerateTests metric with types telemetry: add amazonq_utgGenerateTests metric with types Dec 5, 2024
@justinmk3 justinmk3 merged commit 4cff9a9 into aws:main Dec 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants