Amazon Q Code Transformation maven telemetry changes #681
Conversation
damntrecky
changed the title
| @@ -1078,14 +1078,24 @@ | |||
| ] | |||
| }, | |||
| { | |||
| "name": "codeTransformMavenBuildCommand", | |||
| "name": "codeTransformCommandExecutables", | |||
There was a problem hiding this comment.
Maybe rename to codeTransformBuildToolExecutable
There was a problem hiding this comment.
I'm trying to get a more generic name as we might not only add build commands here. Could be other setup commands for other build tools and looking ahead other programs.
| "required": true | ||
| }, | ||
| { | ||
| "type": "codeTransformRuntimeError", |
There was a problem hiding this comment.
We already put the failure reason under reason -- do we want this so that we can hard-code the reason field?
There was a problem hiding this comment.
My thoughts: We will use the reason field to have MavenInstall or MavenCopy and the runtime error will be the output of the command.
| @@ -3556,6 +3566,14 @@ | |||
| "type": "codeTransformSessionId", | |||
| "required": true | |||
| }, | |||
| { | |||
| "type": "codeTransformRuntimeError", | |||
| "required": true | |||
There was a problem hiding this comment.
Should be false because it's not always applicable. Either way this was merged recently in my PR.
There was a problem hiding this comment.
Noted: should make sure this is updated to false during merge/rebase
| "required": true | ||
| }, | ||
| { | ||
| "type": "codeTransformCommandNames", |
There was a problem hiding this comment.
Why do we need this field here? I don't think it applies to this metric, besides for javap, but we already handle that: codeTransformPreValidationError: 'NoJavaProject'
There was a problem hiding this comment.
My thought: There are sub groups within the preValidationError. For example 'NoJavaProject' can have two different paths to trigger in VSCode right?
| "name": "codeTransformCommandNames", | ||
| "type": "string", | ||
| "description": "Type of maven, gradle and other command line arguments run in the IDE", | ||
| "allowedValues": [ |
There was a problem hiding this comment.
I do agree that we need something like this for the shell commands
There was a problem hiding this comment.
Lets exhaust all the options we want in here offline.
| @@ -1078,14 +1078,24 @@ | |||
| ] | |||
| }, | |||
| { | |||
| "name": "codeTransformMavenBuildCommand", | |||
| "name": "codeTransformCommandExecutables", | |||
| "type": "string", | |||
| "description": "Type of maven command", | |||
| "allowedValues": [ | |||
| "mvn", | |||
| "mvnw", | |||
There was a problem hiding this comment.
Potentially add mvn.cmd and mvnw.cmd? Or a boolean field for Windows?
| @@ -3530,6 +3540,26 @@ | |||
| } | |||
| ] | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
We need to add an event to trigger for when projects have not yet initiated transformation to get user details. This is a P0 requirement.
Problem
Logging for maven build failures is a bit under thought. We want to introduce some slight changes that we think will help normalize logging these failures for Telemetry/BI.
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.