Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS_CONTAINER_AUTHORIZATION_TOKEN as default value for SSRF_ENV_VARIABLES #28

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

dhinakk
Copy link
Contributor

@dhinakk dhinakk commented Sep 18, 2024

Description of changes:
This change adds AWS_CONTAINER_AUTHORIZATION_TOKEN as a default value for SSRF_ENV_VARIABLES config in addition to the already existing values AWS_TOKEN and AWS_SESSION_TOKEN.

The AWS_CONTAINER_AUTHORIZATION_TOKEN env variable contains the authorization token in ECS, EKS and even in Java Lambda's when SnapStart is enabled. Adding this env variable as another default value to SSRF_ENV_VARIABLES allows the Secrets Manager Agent to be used in the above containerized environments without developers having to manually add it.

Refer :

Verification

  • cargo build succeeds and all unit tests pass.
  • Manually tested by creating an Java Lambda Extension with SnapStart enabled, using the example provided, and verified that the Agent is able to retrieve secrets.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dhinakk dhinakk requested a review from a team as a code owner September 18, 2024 23:31
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (2081106) to head (c9174c3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   68.89%   68.80%   -0.10%     
==========================================
  Files          14       14              
  Lines        2887     2885       -2     
  Branches       11       10       -1     
==========================================
- Hits         1989     1985       -4     
- Misses        898      900       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhinakk dhinakk force-pushed the ssrf_env_config_default branch from 50c35ea to c9174c3 Compare September 19, 2024 16:30
@dhinakk dhinakk merged commit c604b4b into aws:main Sep 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants