-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codegen changes for AuthSchemeInterceptorSpecs to update the RegionSet from Execution Attributes #5768
Codegen changes for AuthSchemeInterceptorSpecs to update the RegionSet from Execution Attributes #5768
Conversation
@@ -148,20 +149,17 @@ private MethodSpec generateAuthSchemeParams() { | |||
if (!authSchemeSpecUtils.useEndpointBasedAuthProvider()) { | |||
builder.addStatement("$T operation = executionAttributes.getAttribute($T.OPERATION_NAME)", String.class, | |||
SdkExecutionAttribute.class); | |||
builder.addStatement("$T.Builder builder = $T.builder().operation(operation)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is needed because earlier Builder was built in a single line
Since we have conditional bases builder for sigv4a so splited this generation code
QueryAuthSchemeParams.builder().operation(operation).region(region).build();
Quality Gate passedIssues Measures |
@@ -0,0 +1,4 @@ | |||
{ | |||
"skipEndpointTestGeneration": true, | |||
"useMultiAuth": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline, we should consider removing useMultiAuth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added JAVA-8023
and also added in planning
Motivation and Context
(Note Will raise a separate PR later for EndpointBased Auth case that is legacy service like SES , S3 etc)
Modifications
Generated Code looks like below
Testing
Screenshots (if appropriate)
License