Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AuthScemeParams with RegionSet for Sigv4a auth Scheme #5766

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Update AuthScemeParams with RegionSet for Sigv4a auth Scheme #5766

merged 1 commit into from
Dec 30, 2024

Conversation

joviegas
Copy link
Contributor

Motivation and Context

  • Update AuthScemeParams with RegionSet for Sigv4a auth Scheme
  • These regionSet parameter will be updated from ExecutionAttributes in the AuthScemeInterceptor (later PR)

Modifications

  • Updated AuthSchemeParamsSpec and DefaultAuthSchemeParamsSpec to generate code only if Sigv4a Auth is defined.

Testing

  • Junits

Screenshots (if appropriate)

License

  • I confirm that this pull request can be released under the Apache 2 license

@joviegas joviegas requested a review from a team as a code owner December 30, 2024 20:03
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.3% Coverage on New Code
1.6% Duplication on New Code

See analysis details on SonarQube Cloud

@joviegas joviegas merged commit 066cca3 into feature/master/multi-auth-sigv4a Dec 30, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidh44 davidh44 davidh44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joviegas @davidh44