Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Multi Auth Sigv4a for Service metadata #5761

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Add support for Multi Auth Sigv4a for Service metadata #5761

merged 2 commits into from
Dec 24, 2024

Conversation

joviegas
Copy link
Contributor

Motivation and Context

Support sigv4a auth

"metadata": {
    "apiVersion": "2015-07-09",
    "endpointPrefix": "foo",
    "protocol": "rest-json",
    "serviceFullName": "Amazon Foo Service",
    "serviceId": "Foo",
    "signatureVersion": "v4",
    "auth": ["aws.auth#sigv4a" ,"aws.auth#sigv4"],
    "uid": "foo-2015-07-09"
}

Modifications

  • Added new AuthType
  • Added Default Authscheme creation for sigv4a in codegen

Note : Separate PR will be created for operation with Sigv4a trait and unsignedPayload. This PR is sepcific just to service metadata

Testing

  • Added Junits in codegen

License

  • I confirm that this pull request can be released under the Apache 2 license

@joviegas joviegas requested a review from a team as a code owner December 24, 2024 19:55
@joviegas joviegas changed the title Add support for Multi Auth Sihv4a for Service metadata Add support for Multi Auth Sigv4a for Service metadata Dec 24, 2024
@joviegas joviegas force-pushed the joviegas/auth-traits branch from bc249c5 to 73929a9 Compare December 24, 2024 20:01
joviegas
joviegas commented Dec 24, 2024
View reviewed changes
codegen/src/test/java/software/amazon/awssdk/codegen/poet/auth/scheme/AuthSchemeSpecTest.java
@@ -199,6 +206,14 @@ static class TestCase {
private final String outputFileSuffix;
private final String caseName;


@Override
public String toString() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to get the Test case names in the Parameterized test case titles for each tests

dagnir
dagnir reviewed Dec 24, 2024
View reviewed changes
codegen/src/main/java/software/amazon/awssdk/codegen/model/service/AuthType.java Outdated
@@ -24,6 +24,7 @@ public enum AuthType {
CUSTOM("custom"),
IAM("iam"),
V4("v4"),
V4a("v4a"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why not V4A?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, changed to V4A

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@joviegas joviegas merged commit 8f58170 into feature/master/multi-auth-sigv4a Dec 24, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagnir dagnir dagnir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joviegas @dagnir