SigV4A auth selection update #3225
Merged
+44
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbiscigl
approved these changes
Dec 17, 2024
| @@ -208,6 +208,37 @@ protected void addRequestIdToResults(final ServiceModel serviceModel) { | |||
| }); | |||
| } | |||
|
|
|||
| private static Set<String> servicesMissingMultiAuthMRAPTrait = new HashSet<>(); | |||
There was a problem hiding this comment.
nit: could just do
private static Set<String> servicesMissingMultiAuthMRAPTrait = ImmutableSet.of(
"S3",
"S3-CRT",
"CloudFront KeyValueStore",
"SESv2",
"EventBridge",
)intead of having to have a static block, imo avoiding the static block is nice
sbera87
reviewed
Dec 17, 2024
| context.put("multiRegionAccessPointSupported", true); | ||
| } | ||
| // todo: remove these checks later | ||
| if (serviceModel.getEndpointRules().contains("\"sigv4a\"") && |
There was a problem hiding this comment.
besides endpoint rules, I think we should also check in operations. at operation level there can be authscheme in "auth" field (example cognito idp, even though its no auth but we just add the infra in case of operation level support)
There was a problem hiding this comment.
updated, thank you.
although, I'm not sure we need to check for noauth or bearer per operation.
This block is for enabling MRAP flag only, not for c2j model validation.
SergeyRyabinin
force-pushed
the
sr/MultiAuth
branch
from
7d0fcd6 to
a72da65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
specification update
Description of changes:
c2j models now have an
authlist metadata that represents a list of supported Auth Schemes on the service client.SDKs must rely on this trait to generate a SigV4-Asymmetric signer instead of Endpoint Rules.
(with the exception of 4 service clients at the moment whose service models are non-compliant on this regard
S3
CloudFront KeyValueStore
SESv2
EventBridge)
tested by generating all and seeing no diff is generated (as expected now).
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.