Extend kmstools to get Encryption Context from CLI #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugkoira
previously approved these changes
Dec 12, 2024
| @@ -91,6 +91,7 @@ if (NOT WIN32) | |||
| set_target_properties(${PROJECT_NAME} PROPERTIES SOVERSION 0unstable) | |||
|
|
|||
| target_compile_definitions(${PROJECT_NAME} PUBLIC) | |||
| target_compile_options(${PROJECT_NAME} PRIVATE "-Wall" "-Werror" "-Wpedantic") | |||
There was a problem hiding this comment.
would be better to have it in a separate commit
There was a problem hiding this comment.
Only for the SDK library, or for the library and the binaries?
There was a problem hiding this comment.
Re-pushed the branch, making this line a separate commit.
There was a problem hiding this comment.
meant for both, but was more a nit
|
Can/will the same change be done for |
Can do, but probably in a separate PR. The reason is, Encryption contexts should also supported for the |
This commit modifies `kmstool-instance` to be able to pass Encryption context from command line arguments. Context shall be passed using the new `--encryption-context KEY=VAL` argument. User can specify multiple key-value pairs via an invocation like `--encryption-context KEY1=VALUE1 --encryption-context KEY2=VALUE2`. Application `kmstool-enclave` has been modified to process Encryption context from the received command, and pass it further to the KMS API.
This commit adds flags `-Wall`, `-Werror`, and `-Wpedantic` to the SDK library target.
atanzu
force-pushed
the
feature/pass-encryption-context-as-cli-args
branch
from
43dfbf5 to
f28070f
Compare
eugkoira
approved these changes
Dec 12, 2024
foersleo
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies
kmstool-instanceto be able to pass Encryption context from command line arguments. Context shall be passed using the new--encryption-context KEY=VALargument. User can specify multiple key-value pairs via an invocation like--encryption-context KEY1=VALUE1 --encryption-context KEY2=VALUE2.Application
kmstool-enclavehas been modified to process Encryption context from the received command, and pass it further to the KMS API.Issue #143