feat: implement sliding expiration cache classes #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenc-bq
force-pushed
the
feat/sliding-expiration-cache
branch
2 times, most recently
from
d6499fb to
0f546a1
Compare
karenc-bq
force-pushed
the
feat/sliding-expiration-cache
branch
from
0f546a1 to
6bc8b1e
Compare
jkwuc89
reviewed
Dec 18, 2024
jkwuc89
reviewed
Dec 18, 2024
There was a problem hiding this comment.
The implementation looks good to me. 👍
I suggest adding unit tests. You may be able to leverage the sliding cache tests inside aws-rds-odbc as a starting point. See https://github.com/aws/aws-rds-odbc/blob/main/test/unit_test/util/sliding_cache_map_test.cc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
Review Status
Additional Reviewers