Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Docker image for CI integration jobs #2126

Merged
merged 6 commits into from
Jan 31, 2025

Conversation

nhatnghiho
Copy link
Contributor

Description of changes:

Install packages needed for running CI integration jobs successfully.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

Copy link
Contributor

@andrewhop andrewhop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious how big is this image now? I'm thinking about how long it will take to pull from ECR and if we want this all in the base or a specific integration test image.

@nhatnghiho
Copy link
Contributor Author

nhatnghiho commented Jan 18, 2025

Curious how big is this image now? I'm thinking about how long it will take to pull from ECR and if we want this all in the base or a specific integration test image.

ubuntu-22.04:gcc-12x right now is around 1.05GB, which would be almost a 50% size increase from previously (726MB). I like the idea of creating a separate test image, since a lot of the new packages are quite arbitrary

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.97%. Comparing base (35da9fe) to head (d502580).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2126   +/-   ##
=======================================
  Coverage   78.96%   78.97%           
=======================================
  Files         611      611           
  Lines      105522   105522           
  Branches    14946    14946           
=======================================
+ Hits        83324    83332    +8     
+ Misses      21545    21538    -7     
+ Partials      653      652    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nhatnghiho nhatnghiho marked this pull request as ready for review January 24, 2025 18:00
@nhatnghiho nhatnghiho requested a review from a team as a code owner January 24, 2025 18:00
skmcgrail
skmcgrail previously approved these changes Jan 28, 2025
@nhatnghiho nhatnghiho enabled auto-merge (squash) January 31, 2025 00:05
@nhatnghiho nhatnghiho merged commit a38dc2e into aws:main Jan 31, 2025
121 of 126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants