-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keccak1600_Squeeze/Absorb Layer (rename) #2097
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean redefinition of SHAKE blocksize/rate macros; Update their use inside MLKEM and MLDSA.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2097 +/- ##
=======================================
Coverage 78.74% 78.75%
=======================================
Files 598 598
Lines 103656 103656
Branches 14720 14720
=======================================
+ Hits 81622 81632 +10
+ Misses 21382 21373 -9
+ Partials 652 651 -1 ☔ View full report in Codecov by Sentry. |
jakemas
reviewed
Jan 6, 2025
@@ -64,11 +64,9 @@ extern "C" { | |||
// SHAKE constants, from NIST FIPS202. | |||
// https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.202.pdf | |||
#define SHAKE_PAD_CHAR 0x1F | |||
#define SHAKE128_BLOCKSIZE (KECCAK1600_WIDTH - 128 * 2) / 8 | |||
#define SHAKE256_BLOCKSIZE (KECCAK1600_WIDTH - 256 * 2) / 8 | |||
#define SHAKE128_RATE 168 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for cleaning these (SHAKE128/256_RATE
) up!
jakemas
reviewed
Jan 7, 2025
jakemas
reviewed
Jan 7, 2025
jakemas
reviewed
Jan 7, 2025
Fix alignment Co-authored-by: Jake Massimo <jakemas@amazon.com>
geedo0
reviewed
Jan 7, 2025
geedo0
approved these changes
Jan 7, 2025
jakemas
approved these changes
Jan 7, 2025
andrewhop
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves Keccak1600_ Layer creation, part of #CryptoAlg-2810
Description of changes:
This PR introduces the lowest API layer for SHA3 and SHAKE new API design:
Call-outs:
Remove OPENSSL_EXPORT from some SHA3/SHAKE functions.
Testing:
./crypto/crypto_test --gtest_filter="KeccakInternalTest.*"
./crypto/crypto_test --gtest_filter="SHA3Test.*"
./crypto/crypto_test --gtest_filter="SHAKETest.*"
./crypto/crypto_test --gtest_filter="All/PerKEMTest.*"
./crypto/crypto_test --gtest_filter="All/PQDSAParameterTest.*"
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.