sha + chacha: Move AArch64/X86-64 dispatching to C. #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1625 +/- ##
==========================================
- Coverage 78.35% 78.34% -0.02%
==========================================
Files 573 575 +2
Lines 96123 96213 +90
Branches 13780 13807 +27
==========================================
+ Hits 75318 75378 +60
- Misses 20200 20221 +21
- Partials 605 614 +9 ☔ View full report in Codecov by Sentry. |
justsmth
force-pushed
the
upstream-sha-asm
branch
4 times, most recently
from
f0882e2 to
9cad985
Compare
justsmth
force-pushed
the
upstream-sha-asm
branch
5 times, most recently
from
4ed6b05 to
5baec02
Compare
justsmth
changed the title
justsmth
force-pushed
the
upstream-sha-asm
branch
2 times, most recently
from
14ab57e to
732f161
Compare
justsmth
force-pushed
the
upstream-sha-asm
branch
2 times, most recently
from
df91ba2 to
01d588f
Compare
nebeid
reviewed
Jun 20, 2024
justsmth
force-pushed
the
upstream-sha-asm
branch
3 times, most recently
from
666dc7e to
6294daa
Compare
nebeid
previously approved these changes
Jun 21, 2024
|
PR for reverting a commit that this depends on: #1656 |
|
This PR can include the skipped commit google/boringssl@f5e0c8f (in upstream merge 2024-06-24). The commit including conflict resolution is in the attached file. |
justsmth
changed the title
justsmth
force-pushed
the
upstream-sha-asm
branch
4 times, most recently
from
1c70eac to
698d953
Compare
justsmth
changed the title
justsmth
force-pushed
the
upstream-sha-asm
branch
from
698d953 to
7f7835a
Compare
nebeid
previously approved these changes
Jul 19, 2024
justsmth
changed the title
Take a step towards removing all dispatching logic from assembly for AArch64 and X86-64. Change-Id: I1c965012e81837ff228c810d54e730c525cad54f Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/64208 Reviewed-by: Bob Beck <bbe@google.com> Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: David Benjamin <davidben@google.com>
The x86-64 and x86 code both have 4x and 1x SSSE3 code paths. Only the x86-64 version is modified here. (For 32-bit x86, it looks like it would be much harder to separate the 1x and 4x code paths into separate functions and there's little motivation to do so. So it is likely that 32-bit x86 would define |CHACHA20_ASM_SSSE3| without |CHACHA20_ASM_SSSE3_4X|.) Bug: 673 Change-Id: I48a3fb8a2c6eb05a33c5ef20efff7ed000e51d71 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/64467 Reviewed-by: Bob Beck <bbe@google.com> Reviewed-by: David Benjamin <davidben@google.com> Commit-Queue: David Benjamin <davidben@google.com>
justsmth
force-pushed
the
upstream-sha-asm
branch
from
0ebf3f5 to
9f17d95
Compare
nebeid
approved these changes
Jul 29, 2024
dkostic
approved these changes
Jul 29, 2024
skmcgrail
added a commit
that referenced
this pull request
Aug 1, 2024
## What's Changed * Added options to x509 tool by @ecdeye in #1696 * Add support to detect Neoverse V2 cores by @andrewhop in #1706 * Move OCSP functions for Ruby out of internal.h by @samuel40791765 in #1704 * Add aes-256-xts to EVP_get_cipherbyname by @torben-hansen in #1707 * Match using CMAKE_SYSTEM_PROCESSOR_LOWER by @justsmth in #1709 * Update MySQL to 9.0.0 by @skmcgrail in #1685 * [EC] Unify scalar multiplication for P-256/384/521 by @dkostic in #1693 * Adds const qualifier to ciphertext parameter in EVP_PKEY_decapsulate by @maddeleine in #1713 * Upstream merge 2024 06 24 by @nebeid in #1661 * NIST SP 800-108r1-upd1: KDF Counter Implementation by @skmcgrail in #1644 * Upstream merge 2024 07 09 by @nebeid in #1694 * Design for support of HMAC precomputed keys by @fabrice102 in #1574 * Fix for select point from table in ec_nistp scalar_mul by @dkostic in #1719 * X509toolcomparison by @ecdeye in #1714 * AWS-LC s2n-bignum update 2024-07-22 by @dkostic in #1718 * Add OpenVPN to CI by @smittals2 in #1705 * Lower required Go version, add CI test for specific version by @andrewhop in #1717 * ec2-test-framework enhancements and graviton 4 testing by @samuel40791765 in #1715 * sha + chacha: Move AArch64/X86-64 dispatching to C. by @justsmth in #1625 * Show number of pruned ec2 instances in dashboard by @samuel40791765 in #1728 * rsa and md5 tools by @ecdeye in #1722 * FIPS 203 IPD update: ML-KEM-IPD-768 and ML-KEM-IPD-1024 by @jakemas in #1724 * bump mysql CI to 9.0.1 by @samuel40791765 in #1727 * Support utility OCSP request functions by @samuel40791765 in #1708 * add support for OCSP_SINGLERESP functions by @samuel40791765 in #1703
This was referenced Aug 1, 2024
lilpoozie2005
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream Commits:
Take a step towards removing all dispatching logic from assembly for AArch64 and X86-64.
Change-Id: I1c965012e81837ff228c810d54e730c525cad54f
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/64208
Reviewed-by: Bob Beck bbe@google.com
Commit-Queue: David Benjamin davidben@google.com
Reviewed-by: David Benjamin davidben@google.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.