Stabilize ML-KEM & KDFs; bump to v1.12.0 #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #628 +/- ##
==========================================
- Coverage 95.80% 92.89% -2.91%
==========================================
Files 61 67 +6
Lines 8143 9717 +1574
Branches 0 9717 +9717
==========================================
+ Hits 7801 9027 +1226
- Misses 342 402 +60
- Partials 0 288 +288 ☔ View full report in Codecov by Sentry. |
skmcgrail
reviewed
Dec 11, 2024
justsmth
force-pushed
the
stabilize-ml-kem
branch
from
88ef65d to
d52ed01
Compare
justsmth
changed the title
justsmth
force-pushed
the
stabilize-ml-kem
branch
from
d52ed01 to
9b69f03
Compare
skmcgrail
reviewed
Dec 12, 2024
justsmth
force-pushed
the
stabilize-ml-kem
branch
2 times, most recently
from
06b9f42 to
1b8bcb4
Compare
justsmth
changed the title
justsmth
commented
Dec 12, 2024
Comment on lines
+365
to
+366
| #[cfg(test)] | ||
| mod more_tests { |
There was a problem hiding this comment.
These tests were previously to check behavior when "fips" was enabled, but they probably aren't needed now.
justsmth
force-pushed
the
stabilize-ml-kem
branch
from
1b8bcb4 to
de40195
Compare
justsmth
force-pushed
the
stabilize-ml-kem
branch
from
cea4c71 to
0b172b8
Compare
skmcgrail
approved these changes
Dec 16, 2024
samuel40791765
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
kemmodule.kdfmodule.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.