Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-lc-fips-sys to v0.13.0, align w/ AWS-LC-FIPS-3.0.0 #626

Merged
merged 15 commits into from
Dec 11, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Dec 10, 2024

Description of changes:

Update aws-lc-fips-sys to v0.13.0, aligning with AWS-LC-FIPS-3.0.0.

Call-outs:

Manual changes:

  • First commit: 224f95e
    • Minor updates to symbol collection logic related to recently added s2n-bignum symbols.
  • Last commit: e395d13
    • Update FIPS indicator tests for operations now supported w/ v3.0

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner December 10, 2024 20:54
@justsmth justsmth changed the title Generate/aws lc fips sys v0.13.0 Update aws-lc-fips-sys to v0.13.0, align w/ AWS-LC-FIPS-3.0.0 Dec 10, 2024
samuel40791765
samuel40791765 previously approved these changes Dec 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.77%. Comparing base (c358484) to head (e395d13).
Report is 129 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
- Coverage   95.80%   92.77%   -3.03%     
==========================================
  Files          61       67       +6     
  Lines        8143     9858    +1715     
  Branches        0     9858    +9858     
==========================================
+ Hits         7801     9146    +1345     
- Misses        342      427      +85     
- Partials        0      285     +285     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth force-pushed the generate/aws-lc-fips-sys-v0.13.0 branch from eb6cc5c to a19749b Compare December 11, 2024 14:35
@justsmth justsmth force-pushed the generate/aws-lc-fips-sys-v0.13.0 branch from a19749b to 4c0d579 Compare December 11, 2024 17:40
@justsmth justsmth merged commit 3d3da2b into aws:main Dec 11, 2024
247 of 260 checks passed
@justsmth justsmth deleted the generate/aws-lc-fips-sys-v0.13.0 branch December 11, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants