Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to prepare the next operation and it's associated nonce for OpeningKey and SealingKey #619

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

skmcgrail
Copy link
Member

Issues:

Addresses #570

Description of changes:

Provides the ability for a user to precompute the next operation's nonce value for OpeningKey and SealingKey types via OpeningKey::prepare_operation and SealingKey::prepare_operation which return OpeningKeyOpMut and SealingKeyOpMut respectively containing the nonce for the encapsulated operation. Each type provides a nonce() method by which the nonce can be retrieved by the caller prior to invoking each types respective opening and sealing operation which will use the nonce.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@skmcgrail skmcgrail requested a review from a team as a code owner December 2, 2024 23:42
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (c358484) to head (5c56524).
Report is 126 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
- Coverage   95.80%   92.80%   -3.00%     
==========================================
  Files          61       67       +6     
  Lines        8143     9858    +1715     
  Branches        0     9858    +9858     
==========================================
+ Hits         7801     9149    +1348     
- Misses        342      426      +84     
- Partials        0      283     +283     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skmcgrail skmcgrail changed the title Add ability access next operation nonce from OpeningKey and SealingKey Add ability to compute next operation's nonce for OpeningKey and SealingKey Dec 3, 2024
@skmcgrail skmcgrail changed the title Add ability to compute next operation's nonce for OpeningKey and SealingKey Add ability to compute prepare the next operation and it's associated nonce for OpeningKey and SealingKey Dec 3, 2024
@skmcgrail skmcgrail changed the title Add ability to compute prepare the next operation and it's associated nonce for OpeningKey and SealingKey Add ability to prepare the next operation and it's associated nonce for OpeningKey and SealingKey Dec 3, 2024
aws-lc-rs/src/aead.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/aead.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/aead.rs Show resolved Hide resolved
aws-lc-rs/src/aead.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/aead.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/aead.rs Outdated Show resolved Hide resolved
@skmcgrail skmcgrail merged commit dbe12ec into aws:main Dec 4, 2024
256 checks passed
@skmcgrail skmcgrail deleted the nonce branch December 4, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants