-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to prepare the next operation and it's associated nonce for OpeningKey and SealingKey #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #619 +/- ##
==========================================
- Coverage 95.80% 92.80% -3.00%
==========================================
Files 61 67 +6
Lines 8143 9858 +1715
Branches 0 9858 +9858
==========================================
+ Hits 7801 9149 +1348
- Misses 342 426 +84
- Partials 0 283 +283 ☔ View full report in Codecov by Sentry. |
skmcgrail
changed the title
Add ability access next operation nonce from OpeningKey and SealingKey
Add ability to compute next operation's nonce for OpeningKey and SealingKey
Dec 3, 2024
skmcgrail
changed the title
Add ability to compute next operation's nonce for OpeningKey and SealingKey
Add ability to compute prepare the next operation and it's associated nonce for OpeningKey and SealingKey
Dec 3, 2024
skmcgrail
changed the title
Add ability to compute prepare the next operation and it's associated nonce for OpeningKey and SealingKey
Add ability to prepare the next operation and it's associated nonce for OpeningKey and SealingKey
Dec 3, 2024
justsmth
reviewed
Dec 3, 2024
justsmth
approved these changes
Dec 4, 2024
samuel40791765
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses #570
Description of changes:
Provides the ability for a user to precompute the next operation's nonce value for
OpeningKey
andSealingKey
types viaOpeningKey::prepare_operation
andSealingKey::prepare_operation
which returnOpeningKeyOpMut
andSealingKeyOpMut
respectively containing the nonce for the encapsulated operation. Each type provides anonce()
method by which the nonce can be retrieved by the caller prior to invoking each types respective opening and sealing operation which will use the nonce.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.