Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV cleanup; Remove mirai-annotations dependency #609

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

justsmth
Copy link
Contributor

Issues:

Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2

Description of changes:

Describe current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth force-pushed the msrv-cleanup branch 2 times, most recently from cc5c6bb to 8797a33 Compare November 20, 2024 23:12
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 92.72%. Comparing base (c358484) to head (b27dcfe).
Report is 120 commits behind head on main.

Files with missing lines Patch % Lines
aws-lc-rs/src/test.rs 28.57% 5 Missing ⚠️
aws-lc-rs/src/ptr.rs 0.00% 2 Missing ⚠️
aws-lc-rs/src/rsa/encryption/oaep.rs 0.00% 1 Missing ⚠️
aws-lc-rs/src/rsa/key.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
- Coverage   95.80%   92.72%   -3.08%     
==========================================
  Files          61       67       +6     
  Lines        8143     9768    +1625     
  Branches        0     9768    +9768     
==========================================
+ Hits         7801     9057    +1256     
- Misses        342      426      +84     
- Partials        0      285     +285     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@justsmth justsmth marked this pull request as ready for review November 21, 2024 16:11
@justsmth justsmth requested a review from a team as a code owner November 21, 2024 16:11
@justsmth justsmth merged commit 91689c4 into aws:main Nov 21, 2024
245 checks passed
@justsmth justsmth deleted the msrv-cleanup branch November 21, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants