-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AES ECB mode support #597
AES ECB mode support #597
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #597 +/- ##
==========================================
- Coverage 95.80% 92.69% -3.11%
==========================================
Files 61 67 +6
Lines 8143 9772 +1629
Branches 0 9772 +9772
==========================================
+ Hits 7801 9058 +1257
- Misses 342 429 +87
- Partials 0 285 +285 ☔ View full report in Codecov by Sentry. |
aes_ecb_decrypt(key, block); | ||
} | ||
|
||
// This is a sanity check hat should not fail. We validate in `decrypt` that in_out.len() % block_len == 0 for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// This is a sanity check hat should not fail. We validate in `decrypt` that in_out.len() % block_len == 0 for | |
// This is a sanity check that should not fail. We validate in `decrypt` that in_out.len() % block_len == 0 for |
2, | ||
9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like all of these using 2-9 (including the original code). What's the meaning behind the numbers and can we just move them within the macro/abstract them as variables?
Issues:
Resolves #573
Description of changes:
Call-outs:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.