Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable -Woverriding-t-option #584

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Nov 11, 2024

Context

  clang: error: overriding '-mmacosx-version-min=13.7' option with '--target=x86_64-apple-macosx14.2' [-Werror,-Woverriding-t-option]

Description of changes:

  • This change adds the -Wno-overriding-t-option compiler flag when building aws-lc-sys-fips to avoid this failure.

Call-outs:

  • Fixed several new Clippy findings affecting test logic.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (c358484) to head (89c9b55).
Report is 108 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
- Coverage   95.80%   92.62%   -3.18%     
==========================================
  Files          61       67       +6     
  Lines        8143     9544    +1401     
  Branches        0     9544    +9544     
==========================================
+ Hits         7801     8840    +1039     
- Misses        342      430      +88     
- Partials        0      274     +274     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth changed the title [DRAFT] Disable -Woverriding-t-option Disable -Woverriding-t-option Nov 12, 2024
@justsmth justsmth marked this pull request as ready for review November 12, 2024 13:48
@justsmth justsmth requested a review from a team as a code owner November 12, 2024 13:48
@justsmth justsmth requested a review from skmcgrail November 12, 2024 18:24
skmcgrail
skmcgrail previously approved these changes Nov 13, 2024
@justsmth justsmth merged commit 07545ed into aws:main Nov 15, 2024
237 of 246 checks passed
@justsmth justsmth deleted the fix-fips-overriding-t-option branch November 22, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants