Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mirai-analysis CI #538

Closed
wants to merge 1 commit into from
Closed

Conversation

justsmth
Copy link
Contributor

Description of changes:

  • Fix for failing "mirai-analysis" CI step.
  • Address the warnings it was generating.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner September 26, 2024 11:43
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (c358484) to head (1d3ea5a).
Report is 104 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
- Coverage   95.80%   92.62%   -3.18%     
==========================================
  Files          61       67       +6     
  Lines        8143     9372    +1229     
  Branches        0     9372    +9372     
==========================================
+ Hits         7801     8681     +880     
- Misses        342      420      +78     
- Partials        0      271     +271     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

skmcgrail
skmcgrail previously approved these changes Sep 26, 2024
skmcgrail
skmcgrail previously approved these changes Sep 26, 2024
@justsmth justsmth force-pushed the fix-mirai-analysis branch 2 times, most recently from 43e3779 to 5228db1 Compare October 17, 2024 14:56
@justsmth justsmth closed this Oct 17, 2024
@justsmth justsmth deleted the fix-mirai-analysis branch October 17, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants