-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A working FIPS build for Windows #309
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
=======================================
Coverage 95.91% 95.91%
=======================================
Files 60 60
Lines 8522 8522
=======================================
Hits 8174 8174
Misses 348 348 ☔ View full report in Codecov by Sentry. |
2543ee8
to
f6ed0de
Compare
b94fce2
to
d10057f
Compare
b4d20b1
to
11e9fee
Compare
11e9fee
to
90e8cb3
Compare
int ERR_GET_LIB_RUST(uint32_t packed_error); | ||
int ERR_GET_REASON_RUST(uint32_t packed_error); | ||
int ERR_GET_FUNC_RUST(uint32_t packed_error); | ||
AWS_LC_SYS_EXPORT int ERR_GET_LIB_RUST(uint32_t packed_error); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use OPENSSL_EXPORT
from "openssl/base.h"
? Seems like it would come in handy, so we wouldn't need duplicate definitions in both rust_wrapper.h
s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that intended for use outside the library? It might work if we define BORINGSSL_IMPLEMENTATION
and BORINGSSL_SHARED_LIBRARY
prior to its include.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm I was under the impression that these were already defined if we built with AWS-LC.
Not a blocker though, just curious if it was reusable
int ERR_GET_LIB_RUST(uint32_t packed_error); | ||
int ERR_GET_REASON_RUST(uint32_t packed_error); | ||
int ERR_GET_FUNC_RUST(uint32_t packed_error); | ||
AWS_LC_SYS_EXPORT int ERR_GET_LIB_RUST(uint32_t packed_error); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm I was under the impression that these were already defined if we built with AWS-LC.
Not a blocker though, just curious if it was reusable
Issues:
N/A
Description of changes:
vcvarsall.bat
and then display all of the environment variables that were set.Call-outs:
N/A
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.