Add support for signature verification using public key in X509 DER encoding format. #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
- Coverage 95.65% 95.59% -0.06%
==========================================
Files 57 58 +1
Lines 7759 7973 +214
==========================================
+ Hits 7422 7622 +200
- Misses 337 351 +14 ☔ View full report in Codecov by Sentry. |
hansonchar
force-pushed
the
ec-raw-api_verify_sig_with_x509_pubkey
branch
3 times, most recently
from
1ca187e to
fc668d5
Compare
hansonchar
force-pushed
the
ec-raw-api_verify_sig_with_x509_pubkey
branch
2 times, most recently
from
385a831 to
f3ffe79
Compare
hansonchar
force-pushed
the
ec-raw-api_verify_sig_with_x509_pubkey
branch
from
f3ffe79 to
7028729
Compare
hansonchar
force-pushed
the
ec-raw-api_verify_sig_with_x509_pubkey
branch
3 times, most recently
from
9260f9c to
2519e0c
Compare
hansonchar
force-pushed
the
ec-raw-api_verify_sig_with_x509_pubkey
branch
from
2519e0c to
dea1906
Compare
hansonchar
force-pushed
the
ec-raw-api_verify_sig_with_x509_pubkey
branch
2 times, most recently
from
2810a7c to
55669ad
Compare
added 2 commits
January 10, 2024 23:34
public key in X509 DER encoding format. This includes RSA, Ed25519 and EC. Specifically, the changes include: * Add signature::UnparsedPublicKey.new_with_x509() * Add verify_sig_with_x509_pubkey in addition to verify_sig * Add verify_ed25519_signature * Check ed25519 X509 public key prefix
hansonchar
force-pushed
the
ec-raw-api_verify_sig_with_x509_pubkey
branch
from
55669ad to
4ce3cad
Compare
|
I've stashed this PR contents at https://github.com/aws/aws-lc-rs/tree/hansonchar/ec-raw-api_verify_sig_with_x509_pubkey until we have time to review this work as part of the broader service teams' requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses #274
Description of changes:
Currently signature can only be verified with public key provided in Octet String format. This PR would additionally allow signature to be verified with public key provided in X509 DER encoding format.
Call-outs:
This PR is built on top of #259
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.