Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSA KeyPair improvements, TlsProtocolId fix, and API documentation improvements #268

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

skmcgrail
Copy link
Member

Description of changes:

  • Improve API reference documentation
  • Mark TlsProtocolId as non_exhaustive
  • Reduce multiple RSA key verification calls

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@skmcgrail skmcgrail requested a review from a team as a code owner November 2, 2023 22:36
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1bdaefe) 95.61% compared to head (4dc1abd) 95.46%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
- Coverage   95.61%   95.46%   -0.15%     
==========================================
  Files          50       50              
  Lines        6699     6701       +2     
==========================================
- Hits         6405     6397       -8     
- Misses        294      304      +10     
Files Coverage Δ
aws-lc-rs/src/aead/tls.rs 82.94% <ø> (ø)
aws-lc-rs/src/lib.rs 97.22% <ø> (ø)
aws-lc-rs/src/rsa.rs 93.53% <ø> (+0.10%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

justsmth
justsmth previously approved these changes Nov 3, 2023
aws-lc-rs/src/signature.rs Outdated Show resolved Hide resolved
@skmcgrail skmcgrail merged commit d78fd62 into aws:main Nov 8, 2023
99 of 101 checks passed
@skmcgrail skmcgrail deleted the rsa branch November 8, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants