fix: improve ring compat for digest::Algorithm #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
==========================================
- Coverage 95.61% 95.48% -0.13%
==========================================
Files 50 50
Lines 6699 6708 +9
==========================================
Hits 6405 6405
- Misses 294 303 +9
☔ View full report in Codecov by Sentry. |
justsmth
previously approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Relevant Ring API documentation is here: https://docs.rs/ring/latest/ring/digest/struct.Algorithm.html#implementations
justsmth
approved these changes
Nov 2, 2023
skmcgrail
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In 0.17, ring made the
digest::Algorithmfields private and changed them to getter functions:briansmith/ring@a26925c
This change keeps the fields public (to avoid breaking changes) and also includes the functions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.