Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup for fips-api-changes branch #248

Merged
merged 11 commits into from
Oct 20, 2023

Conversation

skmcgrail
Copy link
Member

Description of changes:

Implemented recent changes discussed in offline review.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@skmcgrail skmcgrail requested a review from a team as a code owner October 19, 2023 22:04
@skmcgrail skmcgrail changed the base branch from main to fips-api-changes October 19, 2023 22:05
Copy link
Contributor

@justsmth justsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a side note, the aead.rs file has grown huge. Can the new structs be moved out to their own source files?

aws-lc-rs/src/aead.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/aead.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/aead.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/aead.rs Show resolved Hide resolved
@skmcgrail skmcgrail requested a review from justsmth October 20, 2023 19:16
@skmcgrail skmcgrail merged commit 28d6e27 into aws:fips-api-changes Oct 20, 2023
74 of 80 checks passed
@skmcgrail skmcgrail deleted the final-changes branch October 20, 2023 19:51
skmcgrail added a commit that referenced this pull request Oct 20, 2023
* Migrate ECDSA to FIPS Approved Functions (#188)
* Migrate RSA to FIPS Approved Functions (#196)
* Migrate Agreement to FIPS Approved Functions (#198)
* FIPS AEAD API Types (#207)
* Refactor HKDF for FIPS (#217)
* FIPS Status Indicator (#216)
* Migrate Ed25519 key generation to EVP_PKEY_keygen (#224)
* FIPS Usage Documentation (#231)
* Support for TLS 1.2 PRF (#232)
* Documentation cleanup (#243)
* Cleanup for fips-api-changes branch (#248)
hansonchar pushed a commit to hansonchar/aws-lc-rs that referenced this pull request Oct 21, 2023
* Migrate ECDSA to FIPS Approved Functions (aws#188)
* Migrate RSA to FIPS Approved Functions (aws#196)
* Migrate Agreement to FIPS Approved Functions (aws#198)
* FIPS AEAD API Types (aws#207)
* Refactor HKDF for FIPS (aws#217)
* FIPS Status Indicator (aws#216)
* Migrate Ed25519 key generation to EVP_PKEY_keygen (aws#224)
* FIPS Usage Documentation (aws#231)
* Support for TLS 1.2 PRF (aws#232)
* Documentation cleanup (aws#243)
* Cleanup for fips-api-changes branch (aws#248)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants