Supports compresssed octets format in agreement::agree_ephemeral() #1255 #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
reviewed
Oct 18, 2023
hansonchar
force-pushed
the
main
branch
2 times, most recently
from
9bbb4da to
08d07ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses #ISSUE-1255
Description of changes:
agreement::agree_ephemeral()supports the peer public key in uncompressed octets format, but rejects if the peer public key is in compressed octets format.compute_public_key_compressedtoEphemeralPrivateKeyso that users can retrieve the EC public key in compressed format when applicable.Call-outs:
I've changed the test cases that used to disallow peer public key in compressed format to now allow them.
Testing:
cargo testBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.