Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated aws-lc to v1.16.0, regenerated aws-lc-sys #236

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

skmcgrail
Copy link
Member

Description of changes:

  • Includes fixes for the new prefix build changes from AWS-LC.
  • Updated and regenerated the aws-lc-sys crate to aws-lc v1.16.0.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@skmcgrail skmcgrail requested a review from a team as a code owner October 3, 2023 22:06
@skmcgrail skmcgrail force-pushed the prefix-build-updates branch 2 times, most recently from af66fa0 to dec6567 Compare October 3, 2023 22:56
@skmcgrail skmcgrail marked this pull request as draft October 4, 2023 05:49
justsmth
justsmth previously approved these changes Oct 4, 2023
@skmcgrail skmcgrail force-pushed the prefix-build-updates branch from b4eebd3 to f139182 Compare October 5, 2023 22:59
@skmcgrail skmcgrail requested a review from justsmth October 5, 2023 22:59
@skmcgrail skmcgrail marked this pull request as ready for review October 5, 2023 22:59
@skmcgrail skmcgrail force-pushed the prefix-build-updates branch 3 times, most recently from a744039 to f139182 Compare October 6, 2023 03:06
@justsmth
Copy link
Contributor

justsmth commented Oct 6, 2023

The riscv64 build is failing, but this looks like an issue with the toolchain used by cross-rs.

= note: /usr/lib/gcc-cross/riscv64-linux-gnu/9/../../../../riscv64-linux-gnu/bin/ld: -march=rv64i2p1_m2p0_a2p1_f2p2_d2p2_c2p0_zicsr2p0: unsupported ISA subset `z'

There's an issue related to this reported here: cross-rs/cross#1293

@justsmth justsmth merged commit 3ce0984 into aws:main Oct 6, 2023
216 of 237 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants