Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for signature verification using public key in X509 DER encoding format. #274

Closed
hansonchar opened this issue Nov 15, 2023 · 1 comment

Comments

@hansonchar
Copy link
Contributor

Problem:

In addition to Exposing accessors for private/public key on elliptic curve keys, we need signature verification to support public key in X509 DER encoding format. This is similar to the issue addressed by #256 for key agreement, but for signature verification.

Solution:

The proposed solution is to build on top of #259, but add support for signature verification using public key not only in Octet String format, but also X509 DER encoding format.

  • Does this change any public APIs? If yes, explain.

Adding functions:

  • signature::UnparsedPublicKey.new_with_x509()

  • Which algorithm(s) will this impact?
    RSA, ed25519 and EC

Requirements / Acceptance Criteria:

Signature verification works with public key provided in either Octet String format or X509 DER encoding format.

Yes

  • Testing: How will this change be tested? Call out new integration tests, functional tests, or particularly
    interesting/important unit tests.

Unit tests added to cover RSA, EC and ed25519 for signature verification using public key in X509 DER encoding format. More unit tests will be added if this proposed pull request looks reasonable enough to be potentially accepted.

@justsmth
Copy link
Contributor

justsmth commented Jun 6, 2024

This is an API change that we're not currently planning to make. We will reopen the issue if needed.

@justsmth justsmth closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants