AWS-LC-FIPS 3.0 builds with Clang 19

aws · Dec 3, 2024 · 69266de · 69266de
1 parent 67ebade
commit 69266de
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/aws-lc-fips-sys/builder/cmake_builder.rs b/aws-lc-fips-sys/builder/cmake_builder.rs
@@ -256,12 +256,8 @@ impl CmakeBuilder {
                             }
                         }
                         if compiler.is_like_clang() {
+                            // AWS-LC-FIPS 2.0 was unable to compile with Clang 19
                             emit_warning(&format!("Clang v{major}.{minor}.{patch} detected."));
-                            if major > 18 {
-                                // TODO: Update when FIPS Clang 19 build is fixed
-                                emit_warning("WARNING: FIPS build is known to fail on Clang >= 19. See: https://github.com/aws/aws-lc-rs/issues/569");
-                                return Some(false);
-                            }
                         }
                         return Some(true);
                     }
@@ -425,7 +421,7 @@ impl crate::Builder for CmakeBuilder {
 }
 
 fn parse_version(line: &str) -> Option<(u32, u32, u32)> {
-    let version_pattern = regex::Regex::new(r"\s(\d{1,2})\.(\d{1,2})\.(\d+)").unwrap();
+    let version_pattern = regex::Regex::new(r"\s(\d{1,2})\.(\d{1,2})\.(\d+)").ok()?;
     let captures = version_pattern.captures(line)?;
 
     let major_str = captures.get(1)?.as_str();