a̸l̴l̸ ̶h̷a̴i̴l̶ ̸c̴l̵i̶p̴p̸y̵

aws · Nov 13, 2024 · 113cfff · 113cfff
1 parent 6f3a0e8
commit 113cfff
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 15 deletions.
diff --git a/aws-lc-rs-testing/benches/kem_benchmark.rs b/aws-lc-rs-testing/benches/kem_benchmark.rs
@@ -7,6 +7,7 @@ use aws_lc_rs::{
 };
 use criterion::{criterion_group, criterion_main, Criterion};
 
+#[allow(deprecated)]
 const UNSTABLE_ALGORITHMS: &[Option<&aws_lc_rs::kem::Algorithm<AlgorithmId>>] = &[
     get_algorithm(AlgorithmId::Kyber512_R3),
     get_algorithm(AlgorithmId::Kyber768_R3),

diff --git a/aws-lc-rs/src/cipher.rs b/aws-lc-rs/src/cipher.rs
@@ -670,13 +670,8 @@ fn encrypt(
 ) -> Result<DecryptionContext, Unspecified> {
     let block_len = algorithm.block_len();
 
-    match mode {
-        OperatingMode::CBC => {
-            if (in_out.len() % block_len) != 0 {
-                return Err(Unspecified);
-            }
-        }
-        _ => {}
+    if mode == OperatingMode::CBC && (in_out.len() % block_len) != 0 {
+        return Err(Unspecified);
     }
 
     match mode {
@@ -704,13 +699,8 @@ fn decrypt<'in_out>(
 ) -> Result<&'in_out mut [u8], Unspecified> {
     let block_len = algorithm.block_len();
 
-    match mode {
-        OperatingMode::CBC => {
-            if (in_out.len() % block_len) != 0 {
-                return Err(Unspecified);
-            }
-        }
-        _ => {}
+    if mode == OperatingMode::CBC && (in_out.len() % block_len) != 0 {
+        return Err(Unspecified);
     }
 
     match mode {
@@ -816,6 +806,7 @@ fn decrypt_aes_cbc_mode<'in_out>(
     Ok(in_out)
 }
 
+#[allow(clippy::needless_pass_by_value)]
 fn encrypt_aes_cfb_mode(
     key: &SymmetricCipherKey,
     mode: OperatingMode,
@@ -848,6 +839,7 @@ fn encrypt_aes_cfb_mode(
     Ok(context.into())
 }
 
+#[allow(clippy::needless_pass_by_value)]
 fn decrypt_aes_cfb_mode<'in_out>(
     key: &SymmetricCipherKey,
     mode: OperatingMode,

diff --git a/aws-lc-rs/src/test.rs b/aws-lc-rs/src/test.rs
@@ -202,7 +202,7 @@ impl TestCase {
         let result = if s.starts_with('\"') {
             // The value is a quoted UTF-8 string.
 
-            let mut bytes = Vec::with_capacity(s.as_bytes().len());
+            let mut bytes = Vec::with_capacity(s.len());
             let mut s = s.as_bytes().iter().skip(1);
             loop {
                 let b = match s.next() {