Clippy fixes

Author: justsmth

aws-lc-fips-sys/builder/main.rs

@@ -5,7 +5,6 @@
 
 // Needed until MSRV >= 1.70
 #![allow(clippy::unnecessary_map_or)]
-
 #![allow(clippy::ref_option)]
 // Clippy can only be run on nightly toolchain
 #![cfg_attr(clippy, feature(custom_inner_attributes))]

aws-lc-rs/src/test.rs

@@ -217,9 +217,10 @@ impl TestCase {
                         }
                     }
                     Some(b'"') => {
-                        if s.next().is_some() {
-                            panic!("characters after the closing quote of a quoted string.");
-                        }
+                        assert!(
+                            s.next().is_none(),
+                            "characters after the closing quote of a quoted string."
+                        );
                         break;
                     }
                     Some(b) => *b,
@@ -233,7 +234,7 @@ impl TestCase {
             match from_hex(&s) {
                 Ok(s) => s,
                 Err(err_str) => {
-                    panic!("{} in {}", err_str, s);
+                    panic!("{err_str} in {s}");
                 }
             }
         };

aws-lc-rs/tests/aead_test.rs

@@ -229,7 +229,7 @@ fn test_aead<Seal, Open>(
                     assert_eq!(Err(error::Unspecified), o_result);
                 }
                 Some(error) => {
-                    panic!("Unexpected error test case: {}", error);
+                    panic!("Unexpected error test case: {error}");
                 }
             };
         }

aws-lc-rs/tests/ecdsa_tests.rs

@@ -92,9 +92,9 @@ fn ecdsa_from_pkcs8_test() {
             match (EcdsaKeyPair::from_pkcs8(this_asn1, &input), error) {
                 (Ok(_), None) => (),
                 (Err(e), None) => {
-                    panic!("Failed with error \"{}\", but expected to succeed", e);
+                    panic!("Failed with error \"{e}\", but expected to succeed");
                 }
-                (Ok(_), Some(e)) => panic!("Succeeded, but expected error \"{}\"", e),
+                (Ok(_), Some(e)) => panic!("Succeeded, but expected error \"{e}\""),
                 (Err(actual), Some(expected)) => assert_eq!(format!("{actual}"), expected),
             };
 
@@ -229,7 +229,7 @@ fn test_signature_ecdsa_verify_fixed(data_file: test::File) {
             ("secp256k1", "SHA256") => &signature::ECDSA_P256K1_SHA256_FIXED,
             ("secp256k1", "SHA3-256") => &signature::ECDSA_P256K1_SHA3_256_FIXED,
             _ => {
-                panic!("Unsupported curve+digest: {}+{}", curve_name, digest_name);
+                panic!("Unsupported curve+digest: {curve_name}+{digest_name}");
             }
         };
 

aws-lc-sys/builder/main.rs

@@ -5,7 +5,6 @@
 
 // Needed until MSRV >= 1.70
 #![allow(clippy::unnecessary_map_or)]
-
 #![allow(clippy::ref_option)]
 // Clippy can only be run on nightly toolchain
 #![cfg_attr(clippy, feature(custom_inner_attributes))]