chore(dep): update testify to v1.10.0, add 1.23 to testing #582
+13
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
=======================================
Coverage 73.30% 73.30%
=======================================
Files 26 26
Lines 1487 1487
=======================================
Hits 1090 1090
Misses 324 324
Partials 73 73 ☔ View full report in Codecov by Sentry. |
|
(CC @bmoffatt et al) I use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
NA
Description of changes:
This started as a small PR to update
testifyto v1.10.0, but it ended up requiring a few additional changes to make the linter and test runner happy.v1.55.2->v1.63.4to fix some linter related bugs (this fixes the linter in other recent PRs that are currently open)1.23to the test runner matrixv1.13,v1.14,v1.15, andv1.16from the test runner matrix; these are no longer supported with the current version oftestify.This should not be a problem with future-forward releases, since these are VERY OLD versions of go.go mod tidyto clean up old dependencies, such asgithub.com/stretchr/objxthat are no longer needed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.