Include user specified MSBuild parameters when evaluating MSBuild properties #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arameters include user specified msbuild parameters.
normj
force-pushed
the
normj/use-msbuild-parameters
branch
from
47d76ee to
cac10d2
Compare
| @@ -211,9 +211,10 @@ public static string DeterminePublishLocation(string workingDirectory, string pr | |||
| /// Looks up specified properties from a project. | |||
| /// </summary> | |||
| /// <param name="projectLocation">The location of the project file.</param> | |||
| /// <param name="msBuildParameters">Additonal MSBuild paramteres passed by the user from the commandline</param> | |||
There was a problem hiding this comment.
Suggested change
| /// <param name="msBuildParameters">Additonal MSBuild paramteres passed by the user from the commandline</param> | |
| /// <param name="msBuildParameters">Additional MSBuild parameters passed by the user from the commandline</param> |
| [InlineData("TargetFramework", "", "net6.0")] | ||
| [InlineData("TargetFramework", "/p:NonExistence=net20.0", "net6.0")] | ||
| [InlineData("TargetFramework", "/p:TargetFramework=net20.0", "net20.0")] | ||
| public void TestPropertyEvaluationWithMSBuildParameters(string property, string msbuildparameters, string expectedValue) |
There was a problem hiding this comment.
Worth adding a test case for when more that one property is added by the user?
There was a problem hiding this comment.
I added a couple more test scenarios.
1 task
gcbeattyAWS
approved these changes
Dec 3, 2024
philasmar
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#351
Description of changes:
In the recent release of Amazon.Lambda.Tools we switched to using
dotnet msbuild getpropertycommand to evaluate MSBuild properties likePublishAot. It is possible for users to specify additional MSBuild parameters via the--msbuild-parametersswitch that might affect the evaluation. That is the case of the linked issue.This PR pass along the user specified value for
--msbuild-parametersto thedotnet msbuild getpropertycommand so the evaluation has the full context for evaluation.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.