Sync Master to Dev #349
Merged
Sync Master to Dev #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction-config commands.
boblodgett
approved these changes
Nov 19, 2024
|
|
||
| if (!string.Equals(existingConfiguration?.SnapStart?.ApplyOn?.Value, snapStartApplyOn, StringComparison.Ordinal)) | ||
| { | ||
| request.SnapStart.ApplyOn = snapStartApplyOn; |
There was a problem hiding this comment.
Can existingConfiguration.SnapStart be null here based on the if check? Or does it need to be request.SnapStart?
There was a problem hiding this comment.
existingConfiguration.SnapStart is right. We are checking to see if the specified by the user value snapStartApplyOn is different what is current set on the function ``existingConfiguration.SnapStart. If they are then set the new value on the patch update request` object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Sync the dev branch after releasing the SnapStart work for Amazon.Lambda.Tools
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.