Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update warning for ARM and AMD architectures on Amazon Linux #347

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

gcbeattyAWS
Copy link
Contributor

@gcbeattyAWS gcbeattyAWS commented Nov 13, 2024

Issue #, if available: N/A

Description of changes:

In Amazon.Lambda.Tools if you deploy to the provided.al2023 using ARM64 the tooling displays the following warning.

WARNING: There is an issue with self contained ARM based .NET Lambda functions using custom runtimes that causes functions to fail to run. The following GitHub issue has further information and workaround.
https://github.com/aws/aws-lambda-dotnet/issues/920

This message and associated GitHub issue is out of date because it talks about provided.al2. In provided.al2 the AMD64 version had a compatible libicu version and the ARM64 was too old. Customers work around this by including libicu in there deployment bundle. Our blueprints do this in the csproj using the following

  <ItemGroup>
    <RuntimeHostConfigurationOption Include="System.Globalization.AppLocalIcu" Value="72.1.0.3" />
    <PackageReference Include="Microsoft.ICU.ICU4C.Runtime" Version="72.1.0.3" />
  </ItemGroup>

In provided.al2023 neither architecture have libicu installed but the warning is only coming up for ARM64.

This change does the following:

  1. Updated Amazon.Lambda.Tools so that the warning is displayed for either architecture. Also updated the text of the warning to talk about how this affects both architectures.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gcbeattyAWS gcbeattyAWS requested a review from normj November 13, 2024 17:52
@gcbeattyAWS gcbeattyAWS marked this pull request as ready for review November 13, 2024 17:52
@gcbeattyAWS gcbeattyAWS changed the base branch from master to dev November 13, 2024 18:06
@boblodgett boblodgett requested a review from 96malhar November 13, 2024 18:31
@boblodgett boblodgett requested a review from philasmar November 19, 2024 18:31
@gcbeattyAWS gcbeattyAWS merged commit 21166cb into dev Nov 20, 2024
2 checks passed
@gcbeattyAWS gcbeattyAWS deleted the gcbeatty/msgupdate branch November 20, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants