Address PR comments

aws · Dec 2, 2024 · 8a5608b · 8a5608b
1 parent cac10d2
commit 8a5608b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/Amazon.Common.DotNetCli.Tools/Utilities.cs b/src/Amazon.Common.DotNetCli.Tools/Utilities.cs
@@ -211,7 +211,7 @@ public static string DeterminePublishLocation(string workingDirectory, string pr
         /// Looks up specified properties from a project.
         /// </summary>
         /// <param name="projectLocation">The location of the project file.</param>
-        /// <param name="msBuildParameters">Additonal MSBuild paramteres passed by the user from the commandline</param>
+        /// <param name="msBuildParameters">Additional MSBuild parameters passed by the user from the commandline</param>
         /// <param name="propertyNames">The names of the properties to look up.</param>
         /// <returns>A dictionary of property names and their values.</returns>        
         public static Dictionary<string, string> LookupProjectProperties(string projectLocation, string msBuildParameters, params string[] propertyNames)

diff --git a/test/Amazon.Common.DotNetCli.Tools.Test/UtilitiesTests.cs b/test/Amazon.Common.DotNetCli.Tools.Test/UtilitiesTests.cs
@@ -105,6 +105,8 @@ public void TestHasExplicitSelfContainedFlag(string projectLocation, string msBu
         [InlineData("TargetFramework", "", "net6.0")]
         [InlineData("TargetFramework", "/p:NonExistence=net20.0", "net6.0")]
         [InlineData("TargetFramework", "/p:TargetFramework=net20.0", "net20.0")]
+        [InlineData("TargetFramework", "/p:TargetFramework=net20.0 /p:OutputType=FutureDevice", "net20.0")]
+        [InlineData("OutputType", "/p:TargetFramework=net20.0 /p:OutputType=FutureDevice", "FutureDevice")]
         public void TestPropertyEvaluationWithMSBuildParameters(string property, string msbuildparameters, string expectedValue)
         {
             var projectLocation = "../../../../../testapps/TestFunction";