Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove manual edit comment from .NET TypeConversion #635

Closed
wants to merge 2 commits into from

Conversation

kessplas
Copy link
Contributor

@kessplas kessplas commented Feb 1, 2024

Issue #, if available: n/a

Description of changes: Removes the "manual edit" comment tag from .NET TypeConversion.

This can be merged now that smithy-lang/smithy-dafny#311 is merged.

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@kessplas kessplas marked this pull request as ready for review February 1, 2024 22:14
@kessplas kessplas requested a review from a team as a code owner February 1, 2024 22:14
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, Smithy-Dafny is, regrettably, unstable.
I am working with @robin-aws to manage that.

But since we cannot "just generate" this fix,
we should not merge this.

I will come back and un-block this PR once Smithy-Dafny is stable.

@seebees
Copy link
Contributor

seebees commented Feb 6, 2024

As @texastony says, this is pending work to confirm that smithy-dafny is correct now

@robin-aws
Copy link
Contributor

This should be taken care of automatically when I apply the same changes to this repo as aws/aws-cryptographic-material-providers-library#195

@robin-aws
Copy link
Contributor

Updated from mainline which already has the change from #195, so the changeset is empty and no longer needed

@robin-aws robin-aws closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants