Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: test Python 3.12 in CI #623

Merged
merged 10 commits into from
Oct 31, 2023
Merged

feat: test Python 3.12 in CI #623

merged 10 commits into from
Oct 31, 2023

Conversation

texastony
Copy link
Contributor

@texastony texastony commented Oct 30, 2023 •
edited
Loading

Issue #, if available: Test Python 3.12 in CI.

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

texastony
texastony commented Oct 30, 2023
View reviewed changes
tox.ini Outdated Show resolved Hide resolved
@texastony texastony marked this pull request as ready for review October 30, 2023 23:28
@texastony texastony requested a review from a team as a code owner October 30, 2023 23:28
@texastony texastony marked this pull request as draft October 30, 2023 23:47
@texastony
Copy link
Contributor Author

Finally got all CodeBuild targets to start the tests,
as compared to failing to install either Python or the ESDK!

I am fairly certain everything will pass now.

@texastony texastony marked this pull request as ready for review October 31, 2023 00:50
ajewellamz
ajewellamz approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@ajewellamz ajewellamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@texastony texastony merged commit 93a67d8 into aws:master Oct 31, 2023
87 checks passed
@texastony texastony deleted the tony/fix-py312 branch October 31, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajewellamz ajewellamz ajewellamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@texastony @ajewellamz