Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clarify Key.getAlgorithm/Cipher.getInstance usage #455

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alex-chew
Copy link
Contributor

Description of changes: Adds comments to clarify the intentional usage of Key.getAlgorithm and Cipher.getInstance. This PR does not introduce any functional changes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@alex-chew alex-chew requested a review from a team as a code owner June 11, 2022 14:20
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lavaleri
Copy link
Contributor

@dependabot recreate

@texastony
Copy link
Contributor

@dependabot recreate

This is not a debpendabot branch, so I do not think its commands will work here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants